Skip to content
Snippets Groups Projects
  1. Sep 22, 2016
  2. Sep 21, 2016
  3. Sep 09, 2016
  4. Sep 08, 2016
  5. Sep 06, 2016
  6. Sep 05, 2016
  7. Aug 31, 2016
  8. Aug 25, 2016
  9. Aug 19, 2016
  10. Jul 27, 2016
    • Alex Reisner's avatar
      Merge pull request #1083 from pcantrell/patch-1 · 07980edd
      Alex Reisner authored
      Prevent rake task crash when BATCH not specified
      07980edd
    • Paul Cantrell's avatar
      Prevent rake task crash when BATCH not specified · 76bc7c63
      Paul Cantrell authored
      In Rails 5, `rake geocode:all` crashes:
      
      ```
      $ rake geocode:all CLASS=Whatzit
      rake aborted!
      ArgumentError: comparison of Fixnum with nil failed
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `<'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:217:in `block in in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `loop'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:198:in `in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:120:in `find_in_batches'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/activerecord-5.0.0/lib/active_record/relation/batches.rb:58:in `find_each'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/geocoder-1.2.2/lib/tasks/geocoder.rake:11:in `block (2 levels) in <top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
      /Users/paul/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'
      Tasks: TOP => geocode:all
      (See full trace by running task with --trace)
      ```
      
      The problem seems to be that `find_each` used to default the `batch:` param when it was explicitly set to nil, but now passes an explicit nil on through.
      
      This patch fixes the issue by defaulting the batch size in the rake task.
      76bc7c63
  11. Jun 28, 2016
  12. Jun 27, 2016
  13. Jun 26, 2016
  14. Jun 25, 2016
  15. Jun 09, 2016
  16. Jun 07, 2016
  17. Jun 02, 2016
  18. May 31, 2016
Loading