bugfixes, add tests

lib/geocoder/lookups/baidu.rb

@@ -21,7 +21,7 @@ module Geocoder::Lookup
     def results(query, reverse = false)
       return [] unless doc = fetch_data(query)
       case doc['status']; when 0
-        return [doc['result']]
+        return [doc['result']] unless doc['result'].blank?
       when 1, 3, 4
         raise_error(Geocoder::Error, messages) ||
           warn("Baidu Geocoding API error: server error.")
@@ -46,7 +46,7 @@ module Geocoder::Lookup
         (query.reverse_geocode? ? :location : :address) => query.sanitized_text,
         :ak => configuration.api_key,
         :output => "json"
-      }
+      }.merge(super)
     end
 
   end

lib/geocoder/results/baidu.rb

@@ -43,6 +43,22 @@ module Geocoder::Result
       @data['addressComponent']
     end
 
+    def state_code
+      ""
+    end
+
+    def postal_code
+      ""
+    end
+
+    def country
+      "China"
+    end
+
+    def country_code
+      "CN"
+    end
+
     ##
     # Get address components of a given type. Valid types are defined in
     # Baidu's Geocoding API documentation and include (among others):

test/fixtures/baidu_invalid_key

+{"results":[],"status":5,"msg":"AK Illegal or Not Exist:"}

test/fixtures/baidu_no_results

+{"status":0,"result":[]}

test/fixtures/baidu_reverse

+{"status":0,"result":{"location":{"lng":121.48789948569,"lat":31.249161555654},"formatted_address":"上海市闸北区天潼路619号","business":"七浦路,海宁路,北京东路","addressComponent":{"city":"上海市","district":"闸北区","province":"上海市","street":"天潼路","street_number":"619号"},"cityCode":289}}

test/fixtures/baidu_shanghai_pearl_tower

+{
+	"status":0,
+		"result":{
+			"location":{
+				"lng":116.30814954222,
+				"lat":40.056885091681
+			},
+			"precise":1,
+			"confidence":80,
+			"level":"\u5546\u52a1\u5927\u53a6"
+		}
+}

test/test_helper.rb

@@ -147,6 +147,15 @@ module Geocoder
       end
     end
 
+    class Baidu
+      private
+      def fixture_prefix
+        "baidu"
+      end
+      def default_fixture_filename
+        "baidu_shanghai_pearl_tower"
+      end
+    end
   end
 end