From ff5eb7fb181fad2f80ae1e3a3f23102d7a1f9a26 Mon Sep 17 00:00:00 2001 From: Alexis Lopez Zubieta Date: Wed, 17 Jul 2019 17:45:25 -0500 Subject: [PATCH 1/2] Remove unrequired headers --- .gitlab-ci.yml | 1 - README.md | 0 src/bin/RemoveJob.cpp | 1 - src/bin/UpdateJob.cpp | 1 - src/fileitem-actions/AppImageFileItemActions.cpp | 1 - src/metadata-extractor/AppImageExtractor.cpp | 6 ++++-- 6 files changed, 4 insertions(+), 6 deletions(-) create mode 100644 README.md diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9743c93..ab12640 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,4 +1,3 @@ -## AppImage build:neon-user-lts-deb: image: kdeneon/plasma:user-lts stage: build diff --git a/README.md b/README.md new file mode 100644 index 0000000..e69de29 diff --git a/src/bin/RemoveJob.cpp b/src/bin/RemoveJob.cpp index 6a05749..04268f0 100644 --- a/src/bin/RemoveJob.cpp +++ b/src/bin/RemoveJob.cpp @@ -1,6 +1,5 @@ // libraries #include -#include // local #include "RemoveJob.h" diff --git a/src/bin/UpdateJob.cpp b/src/bin/UpdateJob.cpp index a67f015..c3d26f2 100644 --- a/src/bin/UpdateJob.cpp +++ b/src/bin/UpdateJob.cpp @@ -1,7 +1,6 @@ // libraries #include #include -#include #include #include #include diff --git a/src/fileitem-actions/AppImageFileItemActions.cpp b/src/fileitem-actions/AppImageFileItemActions.cpp index fe6e38b..492a476 100644 --- a/src/fileitem-actions/AppImageFileItemActions.cpp +++ b/src/fileitem-actions/AppImageFileItemActions.cpp @@ -1,7 +1,6 @@ // libraries #include #include -#include #include #include #include diff --git a/src/metadata-extractor/AppImageExtractor.cpp b/src/metadata-extractor/AppImageExtractor.cpp index 56a95d5..6491a2b 100644 --- a/src/metadata-extractor/AppImageExtractor.cpp +++ b/src/metadata-extractor/AppImageExtractor.cpp @@ -5,6 +5,7 @@ #include #include #include +#include // local #include "AppImageExtractor.h" @@ -47,15 +48,16 @@ void KFileMetaData::AppImageExtractor::extract(ExtractionResult* result) { if (!nameValue.isEmpty()) result->add(Property::Title, nameValue); -// Property::Description is not supported until KF5 5.53.0 +// Property::Description and Property::License are not supported until KF5 5.53.0 +#if (QT_VERSION_CHECK(KCONFIG_VERSION_MAJOR, KCONFIG_VERSION_MINOR, KCONFIG_VERSION_PATCH) >= QT_VERSION_CHECK(5, 53, 0)) QString summary = root.value("summary").toString(); if (!summary.isEmpty()) result->add(Property::Description, summary); - QString license = root.value("license").toString(); if (!license.isEmpty()) result->add(Property::License, license); +#endif QJsonValue links = root.value("links"); QJsonObject linksOjbect = links.toObject();; -- GitLab From a5a4495ac1d58401b5f7fdd510a78acd173ce6af Mon Sep 17 00:00:00 2001 From: Alexis Lopez Zubieta Date: Wed, 17 Jul 2019 18:29:27 -0500 Subject: [PATCH 2/2] Add readme --- README.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/README.md b/README.md index e69de29..4654897 100644 --- a/README.md +++ b/README.md @@ -0,0 +1,35 @@ +# Plasma AppImage Integration + +Provide a set of extensions for the Plasma desktop Environment to enhance the AppImage related user experience. + +Features: +- "Add to Launcher", "Remove from Launcher" and "Update" File Item Actions +- Update progress get notified using a KJob +- File Metadata Extractor. Includes the application name, links, license and description. +- Launch assistant to skip the give execution permission step before running an AppImage + +**Notice that this software is under active development and it's not suitable for production yet.** + + +## Build +**Dependencies** +- cmake +- gcc (>=4.8) +- KF5::XmlGui +- KF5::I18n +- KF5::KIO +- KF5::TextWidgets +- KF5::Notifications +- KF5::FileMetaData +- Qt5::Core +- Qt5::Widgets +- Qt5::Network +- Qt5::DBus + +```bash +mkdir build; cd build +cmake -DCMAKE_INSTALL_PREFIX=`kf5-config --prefix` .. +make -j`nproc` +sudo make install + +``` -- GitLab